Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Frosting) Fix line endings in build.sh within template package #2887

Closed
gep13 opened this issue Jul 15, 2020 · 2 comments · Fixed by #2898
Closed

(Frosting) Fix line endings in build.sh within template package #2887

gep13 opened this issue Jul 15, 2020 · 2 comments · Fixed by #2898
Assignees
@devlead
Labels
Bug
Milestone
v1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 15, 2020

When trying to run the build.sh from a new project creation from the template, you are met with the following:

image

This is due to line endings in the file not being compatible when running on a Mac.

This will likely require the addition of a .gitattributes file to the repository to ensure that the line endings are correct.
@gep13
Copy link
Member Author

gep13 commented Jul 15, 2020

This also impacts the build.config file, since the comparison of version number in the build.sh file doesn't work, since the line feeds in the build.config file are CR/LF.

It goes from this:

image

To this, once line feeds are adjusted to LF:

image

@pascalberger pascalberger transferred this issue from cake-archive/frosting Oct 15, 2020
@pascalberger pascalberger added this to the v1.0.0 milestone Oct 15, 2020
@pascalberger pascalberger changed the title Fix line endings in build.sh within template package (Frosting) Fix line endings in build.sh within template package Oct 15, 2020
devlead added a commit to devlead/cake that referenced this issue Oct 15, 2020
@devlead
(cake-buildGH-2887) Enforce bash scrips LF line endings
6c224ad 
* fixes cake-build#2887
devlead added a commit to devlead/cake that referenced this issue Oct 15, 2020
@devlead
(cake-buildGH-2887) Enforce bash scrips LF line endings
67a1fb8 
* fixes cake-build#2887

If already cloned repo endings can be fixed by executing
1. git rm --cached -r .
2. git reset --hard
@devlead devlead mentioned this issue Oct 15, 2020
Merged
@devlead devlead self-assigned this Oct 15, 2020
gep13 added a commit that referenced this issue Oct 15, 2020
@gep13
Merge pull request #2898 from devlead/feature/gh-2887
6553f87 
GH2887: Enforce bash scrips LF line endings
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Bug
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2887: Enforce bash scrips LF line endings devlead/cake
4 participants
@gep13 @devlead @pascalberger @cake-build-bot