Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom contexts should inherit from CakeContextAdapter #2895

Closed
pascalberger opened this issue Oct 15, 2020 · 1 comment · Fixed by #2901
Closed

Custom contexts should inherit from CakeContextAdapter #2895

pascalberger opened this issue Oct 15, 2020 · 1 comment · Fixed by #2901
Assignees
@devlead
Labels
Improvement
Milestone
v1.0.0

Comments

@pascalberger
Copy link
Member

Custom contexts (such as DotCoverContext) should inherit from CakeContextAdapter
@pascalberger pascalberger added this to the v1.0.0 milestone Oct 15, 2020
@pascalberger pascalberger mentioned this issue Oct 15, 2020
Closed
19 tasks
@devlead devlead self-assigned this Oct 15, 2020
devlead added a commit to devlead/cake that referenced this issue Oct 15, 2020
@devlead
(cake-buildGH-2895) Custom contexts : CakeContextAdapter
d314ccc 
- [x] Make CakeContextAdapter overrideable
- [x] src/Cake.Common/Tools/DotCover/DotCoverContext.cs
- [x] src/Cake.Common/Tools/OpenCover/OpenCoverContext.cs
- [x] src/Cake.Common/Tools/SpecFlow/SpecFlowContext.cs
* fixes cake-build#2895
@devlead devlead mentioned this issue Oct 15, 2020
Merged
4 tasks
pascalberger added a commit that referenced this issue Oct 15, 2020
@pascalberger
Merge pull request #2901 from devlead/feature/gh-2895
3800b28 
GH2895: Custom contexts inherit CakeContextAdapter instead of ICakeContext directly
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Improvement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2895: Custom contexts inherit CakeContextAdapter instead of ICakeContext directly devlead/cake
3 participants
@devlead @pascalberger @cake-build-bot