Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# syntax errors in exceptions causes Specre.CLI internal error #2911

Closed
devlead opened this issue Oct 21, 2020 · 1 comment · Fixed by #2912
Closed

C# syntax errors in exceptions causes Specre.CLI internal error #2911

devlead opened this issue Oct 21, 2020 · 1 comment · Fixed by #2912
Assignees
Labels
Milestone

Comments

@devlead
Copy link
Member

devlead commented Oct 21, 2020

I.e. C:/temp/priv/boom.cake(2,8): somewhere in exception message will cause this exception

Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at System.Text.RegularExpressions.RegexReplacement.Replace(MatchEvaluator evaluator, Regex regex, String input, Int32 count, Int32 startat)
   at System.Text.RegularExpressions.Regex.Replace(String input, MatchEvaluator evaluator)
   at Spectre.Console.Internal.MarkupParser.Parse(String text, Style style)
   at Spectre.Cli.Internal.Composer.Render(RenderContext context, Int32 maxWidth)
   at Spectre.Console.AnsiConsoleExtensions.Render(IAnsiConsole console, IRenderable renderable)
   at Spectre.Cli.CommandApp.<RunAsync>d__7.MoveNext()

Identified as upstrem issue ( spectresystems/spectre.cli#117 ) fixed with pr ( spectresystems/spectre.cli#118 ) and release 0.45.0.

I'll submit a PR shortly to address this.

@devlead devlead added the Bug label Oct 21, 2020
@devlead devlead added this to the v1.0.0 milestone Oct 21, 2020
@devlead devlead self-assigned this Oct 21, 2020
devlead added a commit to devlead/cake that referenced this issue Oct 21, 2020
patriksvensson added a commit that referenced this issue Oct 21, 2020
GH2911: Update Specre.CLI to 0.45.0
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants