Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Cake version in build.config #2956

Closed
pascalberger opened this issue Nov 23, 2020 · 4 comments · Fixed by #2946
Closed

Wrong Cake version in build.config #2956

pascalberger opened this issue Nov 23, 2020 · 4 comments · Fixed by #2946
Assignees
Labels
Milestone

Comments

@pascalberger
Copy link
Member

What You Are Seeing?

When creating a new Frosting project from a template a build.config file is included in the bootstrapping scripts, based on the build.config file used to build Cake.

What is Expected?

Cake version in the generated build.config should match the version of the template (e.g. for Cake.Frosting template 1.0 it should use Cake version 1.0)

What version of Cake are you using?

1.0 RC1

Are you running on a 32 or 64 bit system?

64-Bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

  • Install latest Cake Frosting Template
  • Create a new project
@devlead
Copy link
Member

devlead commented Nov 26, 2020

The the template build config for frosting shouldn't have cake version as that's implied, that's an side effect of beeing merged into cake repo.

In frostings case we probably should skip build.config and just use global.json.
Obtain scripts now have an -JSonFile|--jsonfile <JSONFILE> option which can be pointed to global json.
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script
And Cake version could be picked up from tool manifest or in Frosting's case csproj

@devlead
Copy link
Member

devlead commented Dec 1, 2020

I believe this will be fixed by #2946 ?

@pascalberger pascalberger linked a pull request Dec 1, 2020 that will close this issue
@devlead
Copy link
Member

devlead commented Dec 9, 2020

Fixed by #2946

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants