Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICakeArguments.GetArgument extension #3029

Closed
pascalberger opened this issue Jan 13, 2021 · 3 comments · Fixed by #3049
Closed

Add ICakeArguments.GetArgument extension #3029

pascalberger opened this issue Jan 13, 2021 · 3 comments · Fixed by #3049
Assignees
@patriksvensson
Labels
Improvement
Milestone
v1.0.0

Comments

@pascalberger
Copy link
Member

1.0 RC 1 removed Cake.Core.ICakeArguments.GetArgument(System.String) since we now support multiple arguments with the same name. To avoid a breaking change (e.g. when called from an addin) we could add an extension to GetArgument extension to ICakeArguments.
@pascalberger pascalberger added this to the v1.0.0 milestone Jan 13, 2021
@devlead
Copy link
Member

devlead commented Jan 13, 2021

For reference see the discussion #3026

@patriksvensson patriksvensson mentioned this issue Jan 23, 2021
Merged
augustoproiete added a commit that referenced this issue Jan 24, 2021
@augustoproiete
Merge pull request #3049 from patriksvensson/feature/GH-3029-2
4ae42eb 
Add ICakeArguments.GetArgument extension
@pascalberger pascalberger linked a pull request Jan 24, 2021 that will close this issue
Add ICakeArguments.GetArgument extension #3049
Merged
@pascalberger
Copy link
Member Author

Fixed with #3049

@augustoproiete augustoproiete modified the milestones: v1.0.0, v1.0.0-rc0003 Jan 28, 2021
@augustoproiete augustoproiete mentioned this issue Jan 29, 2021
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patriksvensson patriksvensson

Labels
Improvement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add ICakeArguments.GetArgument extension
5 participants
@augustoproiete @patriksvensson @devlead @pascalberger @cake-build-bot