GH-2897: Add tests for MyGetProvider #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlead
force-pushed
the
mygetprovider-tests
branch
from
e8b20ed
to
1e59464
Compare
|
@duracellko your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2897 Add unit tests for MyGetProvider.
Additionally replacement of special characters was rewritten. Although original implementation (surprisingly) worked, it relied on implementation of Dictionary. Problem was that
|should be replaced first, otherwise it would be replaced multiple times. However,Dictionarydoes not guarantee to enumerate items in the same order as they were added to the dictionary. So it was not guaranteed that|would be first token to replace.I changed the replacement to iterate through characters of source string.
Also original code replaced
[by|['. I assume it was type and correct replacement is|[