Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2966: Enable AnsiConsoleRenderer when running on Azure Pipelines #2968

Conversation

augustoproiete
Copy link
Member

Update the AnsiDetector to enable the AnsiConsoleRenderer when Cake is running on Azure Pipelines

image


Partially closes ... #2966 (one more PR to follow)

@augustoproiete
Copy link
Member Author

This PR relates to #2969 and #2970 and touches the same area of the code, so I expect merge conflicts to arise after any of them are merged. It's a simple rebase which I can do as PRs are merged.

I decided to do separate PRs to make sure they don't block each other as they are separate improvements that can be independently merged.

@augustoproiete augustoproiete changed the title (GH-2966) Enable AnsiConsoleRenderer when running on Azure Pipelines GH-2966: Enable AnsiConsoleRenderer when running on Azure Pipelines Dec 15, 2020
@augustoproiete augustoproiete force-pushed the enable-ansiconsole-azure-pipelines branch from d9a1601 to 10d374b Compare December 22, 2020 13:03
@augustoproiete augustoproiete force-pushed the enable-ansiconsole-azure-pipelines branch from 10d374b to bca8ecb Compare January 4, 2021 01:39
@augustoproiete augustoproiete force-pushed the enable-ansiconsole-azure-pipelines branch from bca8ecb to f768c0b Compare January 24, 2021 23:02
@augustoproiete augustoproiete force-pushed the enable-ansiconsole-azure-pipelines branch from f768c0b to 60923fc Compare February 7, 2021 22:18
@devlead devlead force-pushed the enable-ansiconsole-azure-pipelines branch from 60923fc to 70d279f Compare February 13, 2021 15:13
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This also closes #2969 and closes #2970

@devlead devlead linked an issue Feb 13, 2021 that may be closed by this pull request
@devlead devlead force-pushed the enable-ansiconsole-azure-pipelines branch from 70d279f to bbd2ed2 Compare February 13, 2021 15:20
@devlead devlead force-pushed the enable-ansiconsole-azure-pipelines branch from bbd2ed2 to 3210c16 Compare February 13, 2021 15:22
@devlead devlead merged commit 57e7163 into cake-build:develop Feb 13, 2021
@devlead
Copy link
Member

devlead commented Feb 13, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

@augustoproiete augustoproiete deleted the enable-ansiconsole-azure-pipelines branch February 13, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable AnsiConsoleRenderer in TeamCity and Azure Pipelines
2 participants