-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cake Frosting should respect configuration #3048
Cake Frosting should respect configuration #3048
Conversation
@@ -152,7 +153,7 @@ public static CakeHost UsePackageInstaller<TPackageInstaller>(this CakeHost host | |||
/// <param name="host">The <see cref="CakeHost"/> to configure.</param> | |||
/// <param name="uri">The tool URI.</param> | |||
/// <returns>The same <see cref="CakeHost"/> instance so that multiple calls can be chained.</returns> | |||
public static CakeHost UseTool(this CakeHost host, Uri uri) | |||
public static CakeHost InstallTool(this CakeHost host, Uri uri) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm assuming v1.0 we're OK with breaking public APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we're already breaking some APIs 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should create an additional issue for it though so that it will be listed in release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pascalberger +1. I created #3050 & cake-build/website#1504
I tested this one locally on my machine, and everything works (in the sense that tools are installed), but it doesn't honor the Tools Path in I tried:
Test code is on this branch: |
Frosting does not support cake.config. |
Based on the comments in the associated issue, it seems that there is an expectation that the cake.config file will be honoured. |
Ok, then we need to add support for cake.config which has never been supported in Frosting before, and I don't think it should tbh. |
@patriksvensson the title of the issue that this PR is associated with is:
If not cake.config, what configuration is this issue referring to? There isn't any details in the issue. |
Yeah, maybe I'm wrong here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@patriksvensson your changes have been merged, thanks for your contribution 👍 |
This pull request makes sure that Cake.Frosting respect any user configuration related to the tool installation path.