Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3572: Only build TargetFrameworks netcoreapp3.1, net5.0 & net6.0 #3574

Merged
merged 1 commit into from
Oct 17, 2021
Merged

GH3572: Only build TargetFrameworks netcoreapp3.1, net5.0 & net6.0 #3574

merged 1 commit into from
Oct 17, 2021

Conversation

devlead
Copy link
Member

@devlead devlead commented Oct 10, 2021 •
edited by pascalberger
Loading

@devlead devlead force-pushed the feature/gh-3572 branch 6 times, most recently from 8f1d69f to 3a8312e Compare October 10, 2021 07:40
@gep13
Copy link
Member

gep13 commented Oct 10, 2021

Removing OpenCover makes sense, but are we planning on replacing this with something like Coverlet? https://github.com/coverlet-coverage/coverlet

@devlead
Copy link
Member Author

devlead commented Oct 10, 2021

Removing OpenCover makes sense, but are we planning on replacing this with something like Coverlet? https://github.com/coverlet-coverage/coverlet

Probably, what's there now has been disabled for a long time, but yes we can always add something later. Removing the current code meant removing dependency on Mono, which is quite a simplification for our build pipeline.

@devlead devlead force-pushed the feature/gh-3572 branch 7 times, most recently from 993cdf9 to 8439829 Compare October 10, 2021 17:01
@devlead devlead marked this pull request as ready for review October 10, 2021 17:19
pascalberger
pascalberger reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged Azure Pipeline need to be updated as well to get rid of the no longer required installation steps of now unsupported .NET versions

@devlead
Copy link
Member Author

devlead commented Oct 11, 2021

Once this is merged Azure Pipeline need to be updated as well to get rid of the no longer required installation steps of now unsupported .NET versions

Yes, same for Bitrise.

@pascalberger pascalberger mentioned this pull request Oct 11, 2021
Closed
@devlead devlead force-pushed the feature/gh-3572 branch 3 times, most recently from 7ef21c7 to 78c0825 Compare October 11, 2021 22:02
augustoproiete
augustoproiete requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Added a couple of comments.

.github/workflows/build.yml Show resolved Hide resolved
Directory.Build.props Show resolved Hide resolved
build/parameters.cake Outdated Show resolved Hide resolved
src/Cake.Core/IO/ProcessRunner.cs Show resolved Hide resolved
src/Directory.Build.props Show resolved Hide resolved
@devlead devlead force-pushed the feature/gh-3572 branch 6 times, most recently from da4fa02 to e4310e2 Compare October 14, 2021 21:34
augustoproiete
augustoproiete approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nils-a
nils-a approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalberger pascalberger mentioned this pull request Oct 17, 2021
Closed
@nils-a nils-a enabled auto-merge October 17, 2021 20:23
@nils-a nils-a merged commit a7543ce into cake-build:develop Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalberger pascalberger pascalberger left review comments

@augustoproiete augustoproiete augustoproiete approved these changes

@nils-a nils-a nils-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@devlead @gep13 @augustoproiete @nils-a @pascalberger