Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3547: Add DotNetBuild alias (synonym to DotNetCoreBuild) #3620

Merged
merged 1 commit into from
Oct 22, 2021
Merged

GH3547: Add DotNetBuild alias (synonym to DotNetCoreBuild) #3620

merged 1 commit into from
Oct 22, 2021

Conversation

augustoproiete
Copy link
Member

DotNetCore DotNet synonym
DotNetCoreBuild ➡️ 🆕 DotNetBuild
DotNetCoreBuildSettings ➡️ 🆕 DotNetBuildSettings
  • New DotNetBuild aliases are being introduced
  • DotNetBuild aliases contain the code of the existing DotNetCoreBuild (rename/move)
  • Existing DotNetCoreBuild aliases are forwarding calls to newly introduced DotNetBuild aliases
  • New DotNetBuildSettings class is being introduced
  • DotNetBuildSettings class contains the code of DotNetCoreBuildSettings (rename/move)
  • The previous DotNetCoreBuildSettings is now empty and inherits from the new DotNetBuildSettings
  • Namespaces Cake.Common.Tools.DotNetCore.Build.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3547

@augustoproiete augustoproiete requested a review from a team October 21, 2021 00:12
nils-a
nils-a approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@augustoproiete augustoproiete merged commit e357aac into cake-build:develop Oct 22, 2021
@augustoproiete augustoproiete deleted the add-dotnet-build-alias branch October 22, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-a nils-a nils-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetBuild alias (synonym to DotNetCoreBuild)
2 participants
@augustoproiete @nils-a