Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3550: Add DotNetVSTest alias (synonym to DotNetCoreVSTest) #3624

Merged
merged 1 commit into from
Oct 24, 2021
Merged

GH3550: Add DotNetVSTest alias (synonym to DotNetCoreVSTest) #3624

merged 1 commit into from
Oct 24, 2021

Conversation

augustoproiete
Copy link
Member

DotNetCore DotNet synonym
DotNetCoreVSTest ➡️ 🆕 DotNetVSTest
DotNetCoreVSTestSettings ➡️ 🆕 DotNetVSTestSettings
  • New DotNetVSTest aliases are being introduced
  • DotNetVSTest aliases contain the code of the existing DotNetCoreVSTest (rename/move)
  • Existing DotNetCoreVSTest aliases are forwarding calls to newly introduced DotNetVSTest aliases
  • New DotNetVSTestSettings class is being introduced
  • DotNetVSTestSettings class contains the code of DotNetCoreVSTestSettings (rename/move)
  • The previous DotNetCoreVSTestSettings is now empty and inherits from the new DotNetVSTestSettings
  • Namespaces Cake.Common.Tools.DotNetCore.VSTest.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3550

@augustoproiete augustoproiete requested a review from a team October 23, 2021 23:06
devlead
devlead approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 42c043c into cake-build:develop Oct 24, 2021
@devlead devlead deleted the add-dotnet-vstest-alias branch October 24, 2021 08:36
@devlead
Copy link
Member

devlead commented Oct 24, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetVSTest alias (synonym to DotNetCoreVSTest)
2 participants
@augustoproiete @devlead