Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3553: Add DotNetNuGetPush aliases (synonym to DotNetCoreNuGetPush) #3636

Merged
merged 1 commit into from
Oct 26, 2021
Merged

GH3553: Add DotNetNuGetPush aliases (synonym to DotNetCoreNuGetPush) #3636

merged 1 commit into from
Oct 26, 2021

Conversation

augustoproiete
Copy link
Member

@augustoproiete augustoproiete commented Oct 26, 2021 •
edited
Loading

DotNetCore DotNet synonym
DotNetCoreNuGetPush ➡️ 🆕 DotNetNuGetPush
DotNetCoreNuGetPushSettings ➡️ 🆕 DotNetNuGetPushSettings
  • New DotNetNuGetPush aliases are being introduced
  • DotNetNuGetPush aliases contain the code of the existing DotNetCoreNuGetPush (rename/move)
  • Existing DotNetCoreNuGetPush aliases are forwarding calls to newly introduced DotNetNuGetPush aliases
  • New DotNetNuGetPushSettings class is being introduced
  • DotNetNuGetPushSettings class contains the code of DotNetCoreNuGetPushSettings (rename/move)
  • The previous DotNetCoreNuGetPushSettings is now empty and inherits from the new DotNetNuGetPushSettings
  • Namespaces Cake.Common.Tools.DotNetCore.NuGetPush.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3553

@augustoproiete augustoproiete requested a review from a team October 26, 2021 01:25
nils-a
nils-a approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@augustoproiete augustoproiete merged commit d726fa3 into cake-build:develop Oct 26, 2021
@augustoproiete augustoproiete deleted the add-dotnet-push-alias branch October 26, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-a nils-a nils-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetNuGetPush aliases (synonym to DotNetCoreNuGetPush)
2 participants
@augustoproiete @nils-a