Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3671: Detect VS2022 MSBuild when only Build Tools are installed #3678

Merged
merged 1 commit into from
Nov 7, 2021
Merged

GH3671: Detect VS2022 MSBuild when only Build Tools are installed #3678

merged 1 commit into from
Nov 7, 2021

Conversation

augustoproiete
Copy link
Member

Closes #3671

@augustoproiete augustoproiete requested a review from a team November 6, 2021 21:48
@augustoproiete augustoproiete marked this pull request as draft November 7, 2021 13:19
@augustoproiete augustoproiete removed the request for review from a team November 7, 2021 13:20
@augustoproiete augustoproiete force-pushed the detect-vs2022-when-only-build-tools-installed branch from 44141e8 to 8c07105 Compare November 7, 2021 17:16
@augustoproiete augustoproiete marked this pull request as ready for review November 7, 2021 17:36
@augustoproiete augustoproiete requested a review from a team November 7, 2021 17:36
@augustoproiete augustoproiete force-pushed the detect-vs2022-when-only-build-tools-installed branch from 8c07105 to 796b78a Compare November 7, 2021 20:18
devlead
devlead approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit beaab9c into cake-build:develop Nov 7, 2021
@devlead devlead deleted the detect-vs2022-when-only-build-tools-installed branch November 7, 2021 20:43
@augustoproiete augustoproiete mentioned this pull request Nov 23, 2021
Closed
2 tasks
@WGroenestein WGroenestein mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS2022: msbuild can not be located, only Build Tools are installed
2 participants
@augustoproiete @devlead