Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3683: Use DotNetMSBuildSettings instead of DotNetCoreMSBuildSettings on new dotnet aliases settings #3684

Merged
merged 1 commit into from
Nov 8, 2021
Merged

GH3683: Use DotNetMSBuildSettings instead of DotNetCoreMSBuildSettings on new dotnet aliases settings #3684

merged 1 commit into from
Nov 8, 2021

Conversation

augustoproiete
Copy link
Member

Closes #3683

@augustoproiete augustoproiete marked this pull request as ready for review November 8, 2021 04:42
@augustoproiete augustoproiete requested a review from a team November 8, 2021 04:42
@gitfool
Copy link
Contributor

gitfool commented Nov 8, 2021

LGTM

devlead
devlead approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 75d82a2 into cake-build:develop Nov 8, 2021
@devlead devlead deleted the use-dotnet-msbuild-settings-on-new-dotnet-aliases branch November 8, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use DotNetMSBuildSettings instead of DotNetCoreMSBuildSettings on new dotnet aliases settings
3 participants
@augustoproiete @gitfool @devlead