Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3693: Remove 'Core' suffix of some settings classes #3696

Merged
merged 1 commit into from
Nov 14, 2021
Merged

GH3693: Remove 'Core' suffix of some settings classes #3696

merged 1 commit into from
Nov 14, 2021

Conversation

augustoproiete
Copy link
Member

Summary of changes:

  • Update DotNetXXXSettings.Verbosity to use the new DotNetVerbosity (was DotNetCoreVerbosity)
  • Update DotNetXXXSettings.RollForward to use the new DotNetRollForward (was DotNetCoreRollForward)
  • Update all DotNetXXXSettings to inherit from the new DotNetSettings (was DotNetCoreSettings)
  • DotNetVerbosity is now a regular enum the same way that DotNetCoreVerbosity was
  • DotNetRollForward is now a regular enum the same way that DotNetCoreRollForward was
  • DotNetCoreVerbosity is no longer an enum... It's a class that attempts to offer all the features of an enum, and is implicit convertible to DotNetVerbosity for backward compatibility
  • DotNetCoreRollForward is no longer an enum... It's a class that attempts to offer all the features of an enum, and is implicit convertible to DotNetRollForward for backward compatibility

Closes #3693

@augustoproiete augustoproiete force-pushed the remove-core-suffix-in-settings-properties branch 2 times, most recently from 048fb71 to cd2b601 Compare November 14, 2021 00:31
@augustoproiete augustoproiete marked this pull request as ready for review November 14, 2021 00:50
@augustoproiete augustoproiete requested a review from a team November 14, 2021 00:50
@augustoproiete augustoproiete mentioned this pull request Nov 14, 2021
Closed
@augustoproiete augustoproiete force-pushed the remove-core-suffix-in-settings-properties branch from cd2b601 to fd3561f Compare November 14, 2021 13:44
nils-a
nils-a approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete merged commit 105dbc5 into cake-build:develop Nov 14, 2021
@augustoproiete augustoproiete deleted the remove-core-suffix-in-settings-properties branch November 14, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-a nils-a nils-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core suffix is still used in some settings classes
2 participants
@augustoproiete @nils-a