Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH4006: Add missing GitVersion CLI options #4007

Merged

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Oct 22, 2022

Since the initial implementation in Cake, there are a number of new command line options for GitVersion. While it is possible to set these using ArgumentCustomization, these should be supported directly within the Cake settings class.

Fixes #4006

Since the initial implementation in Cake, there are a number of new
command line options for GitVersion. While it is possible to set these
using ArgumentCustomization, these should be supported directly within
the Cake settings class.
@devlead devlead force-pushed the add-missing-cli-options-for-gitversion branch from 1f681f0 to 098355d Compare October 23, 2022 09:36
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 9504860 into cake-build:develop Oct 23, 2022
@devlead
Copy link
Member

devlead commented Oct 23, 2022

@gep13 your changes have been merged, thanks for your contribution 👍

@gep13 gep13 deleted the add-missing-cli-options-for-gitversion branch October 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing GitVersion command line options
2 participants