-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(server): new docs site for ARFlow server #2
Conversation
Thanks for the contribution, a few thoughts of mine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more comments
… to run examples See cake-lab#2 (comment)
The changes look good now. Will merging this PR break the server? Because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I replaced the
static.yml
CI action and thebash
scripts used to build & copy the docs to the static website. We now run all of that on a GitHub runner with a newwebsite.yml
action.Added docs for Protobuf schema, 1 action item left here though: the old
message
field inRegisterResponse
has been changed in the Protobuf schema, but the change has not been reflected in the generated data access layer for the C# client.Centralized all remaining
bash
scripts inpython/
to Poetry scripts insidepyproject.toml
.Added docs for important packages & tools used in the server.