Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Open for checking code) New docs site for ARFlow's Unity Client #3

Merged
merged 25 commits into from
Sep 5, 2024

Conversation

legoeruro
Copy link
Contributor

This is for code review (since most of the things are done). Please don't merge until the other PR is merged.
Once Felix's PR has been merged, I will pull and change some configurations on Unity + merge GitHub actions to make things work.

@YiqinZhao YiqinZhao added WPI Projects created by WPI students. MQP Project related to WPI MQP projects. labels Sep 1, 2024
Copy link
Member

@YiqinZhao YiqinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

unity/Assets/Scripts/ARFlowKuafuData.cs Outdated Show resolved Hide resolved
unity/Documentation/build.cmd Outdated Show resolved Hide resolved
unity/Documentation/docfx.json Outdated Show resolved Hide resolved
@legoeruro legoeruro marked this pull request as ready for review September 4, 2024 15:59
Copy link
Member

@YiqinZhao YiqinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

.github/workflows/website.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@YiqinZhao YiqinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YiqinZhao YiqinZhao merged commit 4892348 into cake-lab:main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MQP Project related to WPI MQP projects. WPI Projects created by WPI students.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants