Automated Integration Tests Flows #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup Pin Code pages
…m/cake-tech/cake_wallet into CW-659-Automated-Integrated-Tests
…CW-659-Automated-Integrated-Tests
…CW-659-Automated-Integrated-Tests
…CW-659-Transaction-History-Automated-Tests
…CW-659-Automated-Integrated-Tests
…m/cake-tech/cake_wallet into CW-659-Restore-Wallets-Automated-Tests
…ub.com/cake-tech/cake_wallet into CW-659-Create-Wallets-Automated-Tests
…b.com/cake-tech/cake_wallet into CW-659-Confirm-Seeds-Display-Correctly
…ub.com/cake-tech/cake_wallet into CW-659-Transaction-History-Automated-Tests
Blazebrain
changed the title
…CW-659-Transaction-History-Automated-Tests
…CW-659-Transaction-History-Automated-Tests
Blazebrain
changed the base branch from
CW-659-Confirm-Seeds-Display-Correctly
to
main
Blazebrain
changed the title
Blazebrain
changed the title
…CW-659-Transaction-History-Automated-Tests
…ing that all wallet types are restored or created correctly
…CW-659-Transaction-History-Automated-Tests
OmarHatem28
approved these changes
Nov 7, 2024
Comment on lines
+86
to
+93
| bool _shouldExitLoop(bool hasTxHistoryWhileSyncing, bool isSynced, bool itemsLoaded) { | ||
| if (hasTxHistoryWhileSyncing) { | ||
| // When hasTxHistoryWhileSyncing is true, exit when status is synced | ||
| return isSynced; | ||
| } else { | ||
| // When hasTxHistoryWhileSyncing is false, exit when status is synced and items are loaded | ||
| return isSynced && itemsLoaded; | ||
| } |
There was a problem hiding this comment.
Minor:
it shouldn't matter, cuz even if the wallet has some transactions while it's syncinc (Monero) then we would also need to check on the itemsLoaded boolean
| secrets.bitcoinTestWalletSeeds, | ||
| ); | ||
|
|
||
| await dashboardPageRobot.confirmWalletTypeIsDisplayedCorrectly(WalletType.bitcoin); |
There was a problem hiding this comment.
better be with a Monero wallet, since bitcoin also fetches the tx history almost immediately
but don't delete this one, just add another case for Monero
…github.com/cake-tech/cake_wallet into CW-659-Transaction-History-Automated-Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
More Automated Integration Tests
Please include a summary of the changes and which issue is fixed / feature is added.
CW-729: Create Wallets Flow Automated Test
CW-730: Restore Wallets Flow Automated Test
CW-731: Transaction History Automated Test
CW-733: Confirm Credentials Display Correctly Automated Test
Pull Request - Checklist