Release v0.18.3.2 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
265d6ca device: set ledger min app version (selsta)
fac7c43 continue pool pruning even if a tx can't be found (j-berman)
1287074 randomx: update submodule (selsta)
876c08d Bump Gitian build instructions to v0.18.1.0 [Release Branch] (Seth For Privacy)
- spend secret key is no longer the sum of multisig key shares; no need to check that is the case upon restore. - restoring a multisig wallet from multisig info means that the wallet must have already completed all setup rounds. Upon restore, set the number of rounds completed accordingly.
- only allow offline wallets to import outputs - don't import empty outputs - export subaddress indexes when exporting outputs
Co-authored-by: woodser <[email protected]>
this will make it easier huge wallets to do so without hitting random limits (eg, max string size in node).
Being offline is not a good enough heuristic, so we keep track of whether the wallet ever refreshed from a daemon, which is a lot better, and probably the best we can do without manual user designation (which would break existing cold wallet setups till the user designates those wallets)
reported by j-berman
multisig: fix segfault restoring encrypted multisig seed
09ee781 build: prepare v0.18.1.1 (selsta)
3679925 Windows: fix unicode file path support (tobtoht)
93db74a rpc: skip bootstrap nodes that are lower than last checkpoint (selsta)
625147e Fix missing semi-colon in error message (j-berman)
e29b2e9 wallet2: ensure imported outputs subaddresses are created (moneromooo-monero) 1d3657a wallet2: better test on whether to allow output import (moneromooo-monero) 0cbf557 allow exporting outputs in chunks (moneromooo-monero) b03d709 wallet2: fixes for export/import output flow (j-berman) 4b7eb57 wallet2: do not assume imported outputs must be non empty (moneromooo-monero) 5b98beb wallet2: prevent importing outputs in a hot wallet (moneromooo-monero) 0de1571 wallet2: fix missing subaddress indices in 'light' exported outputs (moneromooo-monero)
864a78e wallet2: check wallet compatibility with daemon's hard fork version (j-berman)
12e7c41 Merge pull request #5 from j-berman/restore-msig-encrypted-seed (Justin Berman) 848a0c0 Fix segfault restoring encrypted multisig seed (j-berman) 401f5d9 Require user ack multisig is experimental to restore (j-berman) fc8a5d6 multisig: fix monero-project#8537 seed restore (suggestions by @UkoeHB) (j-berman)
f5b8634 Add <cstdint> to aligned test (Lee *!* Clagett)
052df1b Zero initialize rctSigBase elements (Lee *!* Clagett)
fbd0b19 remove ARCH=x86-64 from release-static (woodser)
0cc8f7a cryptonote_core: early out on out of bounds scaling parameter (selsta)
c97c2ec docs: omit i2p port number from ANONYMITY_NETWORKS (selsta)
f2360a7 build: prepare v0.18.3.2 (selsta)
33e3f72 serialization: fix infinite loops and clean up dispatching (jeffro256)
7807f56 unit_tests: fix strtoul unit test (jeffro256)
std::sort is unstable, so it can return random sets of transactions when mempool has many transactions with the same fee/byte. It can result in p2pool mining empty blocks sometimes because it doesn't pick up "new" transactions immediately.
Nodes who see different txs in a double spend attack will drop each other, splitting the network. Issue found by @Boog900.
32b3a56 wallet2: adjust fee during backlog, fix set priority (selsta)
eeb7c7c tx_memory_pool: make double spends a no-drop offense (jeffro256)
36ee12b get_block_template_backlog: better sorting logic (SChernykh)
- Fixed undefined behavior after a call to `remove_tx_from_transient_lists` (it used an invalid iterator) - Fixed `txCompare` (it wasn't strictly weak ordered)
b5b72ae Fixed mempool pruning (SChernykh)
…o release-v0.18.3.2 Fluorine Fermi # -----BEGIN PGP SIGNATURE----- # # iQFJBAABCAAzFiEEh3erj3eO6JSHovjn9KygGDZB4BAFAmXrvy0VHGx1aWdpMTEx # MXdAZ21haWwuY29tAAoJEPSsoBg2QeAQsjMH/AlPMeMlennNpTJ2jISL+lUNc/zK # EpWZxf5dbtHeMKwfu0BDkrzAtvbKB1g38xqnq9nD6iAJ7lnD76IFZ6CrUQVfIr7W # 5S7D0gYN4WkCWQML8gUYO9WKjFLVfy/IsUzEmup5eHI72yflYKjt/N9B/RCE3wbV # C9uYaYhWQHHFTjtmxmMbmtFAJnH9R/D2O+13kfAKmEqM/u+JWoWEuVI/d1JWcJuc # 77vW5D/alzfup7b33mRVvtFDIMAT5fAlSR9+h6aS9GzML4+VwV4ze31fa1nKwVOO # pV/p2iDw9PYgGTJDQflzONKEIxqjw6deTDy6XTAllRqkjx+/8+RMYDC7Jjs= # =2l3y # -----END PGP SIGNATURE----- # Conflicts: # src/wallet/wallet2.cpp # src/wallet/wallet2.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.