Support Literal values in inserts #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
force-pushed
the
feat-literal-insert
branch
6 times, most recently
from
b274511
to
b0afe3a
Compare
MasterOdin
force-pushed
the
feat-literal-insert
branch
from
b0afe3a
to
8b69122
Compare
|
@markstory Do we need to port this to migrations as well? |
MasterOdin
commented
Aug 5, 2024
Comment on lines
+374
to
+376
| if ($value instanceof Literal) { | ||
| return (string)$value; | ||
| } |
There was a problem hiding this comment.
quoteValue is used only in the insert functions for dry-run output as well as two queries in the sqlite adapter where it always operates on a string, so not much risk this breaks something.
phrfpeixoto
reviewed
Aug 13, 2024
| $data = [ | ||
| [ | ||
| 'column1' => 'value1', | ||
| 'column3' => Literal::from('CURRENT_TIMESTAMP'), |
markstory
added a commit
to cakephp/migrations
that referenced
this pull request
Sep 3, 2024
Port cakephp/phinx#2301 to migrations. Fixes #737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2297
PR adds support for using
\Phinx\Util\Literalin insert operations, so that can do stuff like insertCURRENT_TIMESTAMP. Previously, we were always passing all values in the insert data as binded variables to the escaped SQL statement. Now, the literal values will be inserted directly into the escaped SQL statement, while non literals values will continue to be binded.