-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: command for group migration #49
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I tried running Here's the output, with group ID redacted:
|
b5c0578
to
ee4943a
Compare
Sorry didn't mean to mark this one as Draft! |
1c94d66
to
4c691b1
Compare
😲 The command worked today
|
@angela-tran Great news! Do you know why it's printing the last line? 👥 Matching groups (0): qa, mst |
It's from this line in the main logic for the |
Hmm, that line was there even before the CSV output additions, so I'm not sure what its intended purpose was |
It was introduced when there were no subcommands, so maybe it just needs to be wrapped in a conditional? |
Yeah would you mind? It looks a little strange coming after the migrate messages. |
the command operates on a potentially large number of groups and modifies configuration, so this adds a layer of protection against mistakes. note that this commit doesn't change the implementation
4c691b1
to
5d55304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Closes #47
Built off #48This PR adds a subcommand to the
groups
command calledmigrate
. It calls theclient.migrate_concession_group
method that was implemented in #48 for all groups that are returned by any filters given. (If no filters are given, all groups are returned, so all groups would be migrated.)See my comment below on an error I'm seeing when I tried to use
migrate
in the QA environment.