Upload E2E videos on success and failure, cache npm #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelTamaki
force-pushed
the
issue-155
branch
from
3f009bc
to
e90c14d
Compare
MichaelTamaki
changed the title
rmpowell77
approved these changes
Feb 20, 2021
|
just needs approval |
adhamrait
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #155
Upload E2E videos on success and failure
Cache some NPM files as long as
package-lock.jsonstays the same. See https://github.com/actions/cache/blob/main/examples.md#node---npmPre-PR checklist
npm run serveand:npm run lintnpm run test:unitnpm run test:e2eand ran relevant testsScreenshots/GIFs
[Attach screenshots if making a visible change!]