Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buefy package, set basic menu layout, create file + view top menu dropdowns #4

Merged
merged 5 commits into from
Nov 12, 2019
Merged

Add Buefy package, set basic menu layout, create file + view top menu dropdowns #4

merged 5 commits into from
Nov 12, 2019

Conversation

MichaelTamaki
Copy link
Collaborator

@MichaelTamaki MichaelTamaki commented Nov 7, 2019 •
edited
Loading

  • Update readme with figma link and more detailed instructions
  • Add Buefy to packages
    • Add custom colors and import in all Vue components
  • Create basic layout with MenuTop, MenuLeft, MenuRight, and MenuBottom.
  • Use classes in Grapher instead of inline attributes
  • Add dropdowns in top menu that control things like the field dimensions, and toggling the grid
  • Refactor tests to use data-test selectors and utilize initialState()

@MichaelTamaki MichaelTamaki changed the title Layout base Add Buefy package, set basic menu layout, create settings modal Nov 9, 2019
@MichaelTamaki MichaelTamaki changed the title Add Buefy package, set basic menu layout, create settings modal Add Buefy package, set basic menu layout, create file + view top menu dropdowns Nov 10, 2019
@rmpowell77
Copy link
Contributor

Gave it a whirl. Feels good on Chrome, but pretty bad on Safari. it isn't panning smoothly.

rmpowell77
rmpowell77 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@rmpowell77 rmpowell77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look go to me.

rmpowell77
rmpowell77 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@rmpowell77 rmpowell77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@MichaelTamaki MichaelTamaki merged commit cb50732 into master Nov 12, 2019
@MichaelTamaki MichaelTamaki deleted the layout-base branch November 12, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmpowell77 rmpowell77 rmpowell77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelTamaki @rmpowell77