fix: Fix all TS warnings (fix-tsWarnings) #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 336 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/29/2023 01:37:58pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 8a904d3 Started: 11/29/2023 01:26:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Short text question Radio and Short text not required
Retry 1 • Initial Attempt |
0.35% (1)1 / 283 runfailed over last 7 days |
0.35% (1)1 / 283 runflaked over last 7 days |
📄 apps/web/playwright/locale.e2e.ts • 13 Flakes
Top 1 Common Error Messages
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-56.14% (-160)-160 / 285 runsfailed over last 7 days |
56.14% (160)160 / 285 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-55.94% (-160)-160 / 286 runsfailed over last 7 days |
55.94% (160)160 / 286 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-54.58% (-155)-155 / 284 runsfailed over last 7 days |
56.34% (160)160 / 284 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-55.56% (-155)-155 / 279 runsfailed over last 7 days |
57.35% (160)160 / 279 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-57.66% (-158)-158 / 274 runsfailed over last 7 days |
58.03% (159)159 / 274 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-18.32% (-50)-50 / 273 runsfailed over last 7 days |
41.03% (112)112 / 273 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-22.27% (-47)-47 / 211 runsfailed over last 7 days |
40.28% (85)85 / 211 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone required and Address not required
Retry 1 • Initial Attempt |
0.35% (1)1 / 289 runfailed over last 7 days |
2.77% (8)8 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- future Different Locations Tests can add Attendee Phone Number location and book with it
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 242 runsfailed over last 7 days |
8.68% (21)21 / 242 runsflaked over last 7 days |
|
Event Types tests user -- legacy Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 242 runsfailed over last 7 days |
2.89% (7)7 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and Short text question Multiple Email required and Short text required
Retry 1 • Initial Attempt |
0% (0)0 / 290 runsfailed over last 7 days |
1.03% (3)3 / 290 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 1 • Initial Attempt |
2.73% (8)8 / 293 runsfailed over last 7 days |
94.54% (277)277 / 293 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
10.62% (31)31 / 292 runsfailed over last 7 days |
21.23% (62)62 / 292 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.96% (3)3 / 311 runsfailed over last 7 days |
74.60% (232)232 / 311 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
6.15% (19)19 / 309 runsfailed over last 7 days |
90.61% (280)280 / 309 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
2.57% (7)7 / 272 runsfailed over last 7 days |
16.54% (45)45 / 272 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Non admin team members cannot create team in org
Retry 1 • Initial Attempt |
5.81% (18)18 / 310 runsfailed over last 7 days |
26.77% (83)83 / 310 runsflaked over last 7 days |
github-actions
bot
added
the
🚨 merge conflict
gitstart-calcom
requested review from
keithwillcode,
Udit-takkar and
sean-brydon
github-actions
bot
removed
the
🚨 merge conflict
zomars
requested changes
Nov 28, 2023
|
@zomars We updated the PR and now all checks are passing 😄 |
zomars
reviewed
Nov 29, 2023
| @@ -55,9 +53,7 @@ test.describe("Payment app", () => { | |||
| const user = await users.create(); | |||
| await user.apiLogin(); | |||
| const paymentEvent = user.eventTypes.find((item) => item.slug === "paid"); | |||
| if (!paymentEvent) { | |||
There was a problem hiding this comment.
Since we're not type narrowing can we at least assert paymentEvent! as not null? To avoid using paymentEvent?. everywhere
There was a problem hiding this comment.
Hi @zomars, We are asserting about that with the change on line 56
We added it in all cases, if we remove the "?"we would have to use a "!" on paymentEvent const to make sure is not undefined. We can add it and disable ts for that case
Like here:
|
This PR is being marked as stale due to inactivity. |
|
This PR is being closed due to inactivity. Please reopen if work is intended to be continued. |
zomars
reviewed
Jan 4, 2024
Comment on lines
-401
to
-415
| const getStripeCurrency = (stripeMetadata: { currency: string }, credentials: Credential[]) => { | ||
| // Favor the currency from the metadata as EventType.currency was not always set and should be deprecated | ||
| if (stripeMetadata.currency) { | ||
| return stripeMetadata.currency; | ||
| } | ||
|
|
||
| // Legacy support for EventType.currency | ||
| const stripeCredential = credentials.find((integration) => integration.type === "stripe_payment"); | ||
| if (stripeCredential) { | ||
| return (stripeCredential.key as unknown as StripeData)?.default_currency || "usd"; | ||
| } | ||
|
|
||
| // Fallback to USD but should not happen | ||
| return "usd"; | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOW TO RUN THE TESTS
run
yarn lint