fix: before/after event buffers not rendering correctly #13451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
High priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
github-actions
bot
added
🐛 bug
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 444 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/29/2024 03:27:30pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 75da257 Started: 01/29/2024 03:17:17pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- future Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0% (0)0 / 65 runsfailed over last 7 days |
4.62% (3)3 / 65 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and select Question Checkbox Group required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 258 runsfailed over last 7 days |
3.49% (9)9 / 258 runsflaked over last 7 days |
📄 apps/web/playwright/booking/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check availability tab in a event-type Check availability in event type
Retry 1 • Initial Attempt |
18.49% (49)49 / 265 runsfailed over last 7 days |
44.91% (119)119 / 265 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 2 • Retry 1 • Initial Attempt |
5.79% (15)15 / 259 runsfailed over last 7 days |
8.49% (22)22 / 259 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 1 • Initial Attempt |
0.77% (2)2 / 261 runsfailed over last 7 days |
2.30% (6)6 / 261 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 278 runsfailed over last 7 days |
26.26% (73)73 / 278 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.72% (2)2 / 279 runsfailed over last 7 days |
51.97% (145)145 / 279 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-101.46% (-139)-139 / 137 runsfailed over last 7 days |
109.49% (150)150 / 137 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-100.74% (-137)-137 / 136 runsfailed over last 7 days |
102.21% (139)139 / 136 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-101.48% (-137)-137 / 135 runsfailed over last 7 days |
106.67% (144)144 / 135 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-102.22% (-138)-138 / 135 runsfailed over last 7 days |
102.22% (138)138 / 135 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-102.22% (-138)-138 / 135 runsfailed over last 7 days |
102.22% (138)138 / 135 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-102.22% (-138)-138 / 135 runsfailed over last 7 days |
102.22% (138)138 / 135 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-101.48% (-137)-137 / 135 runsfailed over last 7 days |
102.22% (138)138 / 135 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 92 runsfailed over last 7 days |
19.57% (18)18 / 92 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 281 runsfailed over last 7 days |
9.61% (27)27 / 281 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.44% (4)4 / 278 runsfailed over last 7 days |
39.57% (110)110 / 278 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose Inline for First Event Type
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
8.33% (24)24 / 288 runsflaked over last 7 days |
|
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
7.64% (22)22 / 288 runsflaked over last 7 days |
ThyMinimalDev
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13422
Type of change
How should this be tested?
Mandatory Tasks