Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email verification template shows default line heights for texts #16749

Conversation

utkershrajvenshi
Copy link
Contributor

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Make a booking that requires scheduler verification.
  • In the verification email sent to the scheduler, inspect the code in the html structure.
  • In the applied styles, observe that now no line-height is active. Earlier a fixed line-height of 6px was active on this element, which most likely was the cause of the code being masked or rendered unreadable when viewed on some browsers.

Copy link

vercel bot commented Sep 20, 2024

@utkershrajvenshi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Sep 20, 2024
@graphite-app graphite-app bot requested a review from a team September 20, 2024 23:15
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fixed email verification template to show default line heights of text". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email 🐛 bug Something isn't working labels Sep 20, 2024
@utkershrajvenshi utkershrajvenshi changed the title Fixed email verification template to show default line heights of text fix: email verification template shows default line heights for texts Sep 20, 2024
Copy link

graphite-app bot commented Sep 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/20/24)

1 label was added to this PR based on Keith Williams's automation.

@Amit91848
Copy link
Contributor

Amit91848 commented Sep 21, 2024

Were you able to reproduce this issue @utkershrajvenshi? I tried but it works fine for me on edge, chrome and brave. We wouldn't know for sure this actually solves the issue

@utkershrajvenshi
Copy link
Contributor Author

I wasn't able to reproduce this issue on the mentioned browsers either @Amit91848 , I don't have access to Safari so can't comment on that.
I worked based on the most probable cause that could lead to such an issue. As you pointed out, it would be wise to keep this on hold until the effect is clearly reproducible.

@anikdhabal
Copy link
Contributor

@utkershrajvenshi thanks for your work, can't reproduce the issue

@anikdhabal anikdhabal closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verification email's code is illegible / obfuscated / unreadable
3 participants