Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CONTRIBUTING.md and add badges #191

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

eliotwrobson
Copy link
Collaborator

See title, more changes in prep for the upcoming review. Normally wouldn't care too much about this file placement, but this is specifically what is asked fro in their guidelines: https://www.pyopensci.org/python-package-guide/documentation/repository-files/contributing-file.html

Also added badges that are missing from the reviewer checklist: https://www.pyopensci.org/software-peer-review/how-to/reviewer-guide.html#peer-review-template

@eliotwrobson eliotwrobson self-assigned this Dec 6, 2023
@coveralls
Copy link

coveralls commented Dec 6, 2023

Coverage Status

coverage: 99.64%. remained the same
when pulling 186ecd5 on eliotwrobson:contributing_move
into 060f58c on caleb531:develop.

Copy link
Owner

@caleb531 caleb531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's fine! I have no problems with moving CONTRIBUTING.md to the project root, and think it's actually more discoverable that way, anyway.

@eliotwrobson eliotwrobson merged commit 622ad39 into caleb531:develop Dec 6, 2023
7 checks passed
@caleb531 caleb531 mentioned this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants