Use official Flake8 VS Code extension #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the third-party cornflakes-linter VS Code extension to the official / first-parrt Flake8 extension by Microsoft. This should fix some issues I've encountered with the former extension where files within the virtualenv or within Python stdlib were linted when they should have been ignored.
eliotwrobson
approved these changes
Jan 28, 2024
|
@eliotwrobson That's a good point. Especially since the recommendations are just that—they're not required or forced on VS Code users, and can be easily dismissed. With that, I think I'm going to proceed to merge this—thank you for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eliotwrobson Just a small quality-of-life improvement, but with a small caveat, and so want your feedback.
This commit switches the third-party cornflakes-linter VS Code extension
to the official Flake8 extension by Microsoft. I'm hoping this should fix an issue I've encountered with the former extension where files
within the virtualenv or within Python stdlib were linted when they
should have been ignored. I haven't tested that the new extension fixes this, but given that it's first-party, I'm optimistic that it's less buggy.
The catch with this change is that anyone who has installed the official Flake8 extension should uninstall cornflakes-linter (or disable it for the workspace) lest they see duplicate errors in the Problems panel (or otherwise experience other unforeseen conflicts between the extensions).