Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predecessor speed fix #205

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Predecessor speed fix #205

merged 4 commits into from
Feb 1, 2024

Conversation

eliotwrobson
Copy link
Collaborator

Resolves #202. @Tagl you can try this version of the code and see if it gives you the speedup you want.

@eliotwrobson eliotwrobson self-assigned this Feb 1, 2024
@coveralls
Copy link

coveralls commented Feb 1, 2024 •
edited
Loading

Coverage Status

coverage: 99.642% (+0.002%) from 99.64%
when pulling 18b0aba on eliotwrobson:predecessor_speed_fix
into 13e5c1b on caleb531:main.

@eliotwrobson eliotwrobson changed the base branch from main to develop February 1, 2024 22:28
Tagl
Tagl approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Tagl Tagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks (practically) equivalent to the changes I made, but with fixes in additional places in dfa.py.

@eliotwrobson eliotwrobson merged commit b13cddd into caleb531:develop Feb 1, 2024
7 checks passed
@eliotwrobson eliotwrobson deleted the predecessor_speed_fix branch February 1, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tagl Tagl Tagl approved these changes

Assignees

@eliotwrobson eliotwrobson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DFA: maximum_word_length complexity scales with number of final states
3 participants
@eliotwrobson @coveralls @Tagl