Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for text1NumberOfLines and text2NumberOfLines #152

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Add types for text1NumberOfLines and text2NumberOfLines #152

merged 1 commit into from
Feb 20, 2021

Conversation

Nidoe
Copy link
Contributor

@Nidoe Nidoe commented Feb 19, 2021

  • Add text1NumberOfLines and text2NumberOfLines on BaseToastProps in type declaration file

calintamas
calintamas approved these changes Feb 20, 2021
View reviewed changes
Copy link
Owner

@calintamas calintamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@calintamas calintamas merged commit 0f00d7a into calintamas:master Feb 20, 2021
@Nidoe
Copy link
Contributor Author

Nidoe commented Feb 22, 2021

@calintamas Do you mind releasing a new version with these updates?

@Nidoe Nidoe deleted the Add-Props-For-NumOfLines branch February 26, 2021 22:25
@mortocks mortocks mentioned this pull request Jun 27, 2021
Closed
remcorakers pushed a commit to remcorakers/react-native-toast-message that referenced this pull request Mar 15, 2023
@Nidoe
add types for text1NumberOfLines and text2NumberOfLines (calintamas#152)
4e42866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calintamas calintamas calintamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nidoe @calintamas