Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize translateY value to update when keyboard dismisses #342

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Memoize translateY value to update when keyboard dismisses #342

merged 1 commit into from
Mar 31, 2022

Conversation

rcb4t2
Copy link
Contributor

@rcb4t2 rcb4t2 commented Mar 29, 2022

Closes #341

Hi @calintamas! Please take a look at this fix to make keyboard handling more responsive

Copy link
Owner

@calintamas calintamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rcb4t2, thanks for taking the time to look for a fix as well! I'll merge and publish it in the next version

@calintamas calintamas merged commit 73497fa into calintamas:main Mar 31, 2022
@calintamas
Copy link
Owner

Published in v2.1.4

@rcb4t2
Copy link
Contributor Author

rcb4t2 commented Mar 31, 2022

@calintamas Thanks for the quick merge!

@rcb4t2
Copy link
Contributor Author

rcb4t2 commented Mar 31, 2022

@calintamas I installed the latest and it works as expected in most places. We have one call that resolves very fast and the Toast still jumps down, although it's faster than before. It would still be cool to be able to opt out of the keyboard-aware behavior with a config flag. I checked out the implementation and it's a little too in-the-weeds for me to try to PR it, but lmk if I can help!

@calintamas
Copy link
Owner

@rcb4t2 Can you open a feature request issue with this?

@rcb4t2
Copy link
Contributor Author

rcb4t2 commented Mar 31, 2022

@rcb4t2 Can you open a feature request issue with this?

Certainly! #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay after keyboard dismissed
2 participants