Allow style prop to style the base component. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes more sense to name the prop `style` instead of `baseStyle`
akmjenkins
changed the title
calintamas
approved these changes
Nov 29, 2020
There was a problem hiding this comment.
thanks, @akmjenkins!
I'll update the docs and publish it soon
remcorakers
pushed a commit
to remcorakers/react-native-toast-message
that referenced
this pull request
Mar 15, 2023
Allow style prop to style the base component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't get this library to work with @react-navigation/native and react-native-screens. Not sure which library specifically caused the issue, but allowing configuration the base component's style fixed the issue - just added a zIndex 10 and it worked.
There might be a neater way to allow more configuration, like accepting a bunch of props in the base
Toastcomponent that could be passed to theAnimated.View, but this seems a fine enough place to start.Check #92, #85