Backports_lnbits_changes #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
commented
Jun 22, 2023
Comment on lines
+95
to
+101
| try: | ||
| message = self.queue.get(timeout=1) | ||
| self.num_sent_events += 1 | ||
| self.ws.send(message) | ||
| except: | ||
| if shutdown(): | ||
| break |
There was a problem hiding this comment.
Can shutdown worker now via shutdown()
Comment on lines
+134
to
+137
| if self.error_threshold and self.error_counter > self.error_threshold: | ||
| pass | ||
| else: | ||
| self.check_reconnect() |
Comment on lines
+30
to
+33
| self.relays[url].close() | ||
| self.relays.pop(url) | ||
| self.threads[url].join(timeout=1) | ||
| self.threads.pop(url) |
There was a problem hiding this comment.
Remove relays during runtime.
Comment on lines
+45
to
+51
| self.threads[relay.url] = threading.Thread( | ||
| target=relay.connect, | ||
| args=(ssl_options, proxy), | ||
| name=f"{relay.url}-thread", | ||
| daemon=True, | ||
| ).start() | ||
| ) | ||
| self.threads[relay.url].start() |
There was a problem hiding this comment.
We save all threads now.
Comment on lines
+53
to
+59
| self.queue_threads[relay.url] = threading.Thread( | ||
| target=relay.queue_worker, | ||
| args=(lambda: relay.shutdown,), | ||
| name=f"{relay.url}-queue", | ||
| daemon=True, | ||
| ) | ||
| self.queue_threads[relay.url].start() |
There was a problem hiding this comment.
We also save all queue worker threads and add a shutdown argument
| if callback_events_func: | ||
| callback_events_func(event_msg) | ||
| while self.relay_manager.message_pool.has_notices(): | ||
| event_msg = self.relay_manager.message_pool.has_notices() | ||
| event_msg = self.relay_manager.message_pool.get_notice() |
There was a problem hiding this comment.
Endless loop due to has_notice fixed.
vicariousdrama
pushed a commit
to vicariousdrama/python-nostr
that referenced
this pull request
Oct 29, 2023
vicariousdrama
added a commit
to vicariousdrama/python-nostr
that referenced
this pull request
Oct 29, 2023
…bits_changes Changes from callebtc#8
|
Looks good. Any reason not to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes that we made in lnbits/nostrclient