Ar/support sorting by datetime #1
Conversation
| it 'decodes the string succesfully' do | ||
| expect(decoded.id).to eq record.id | ||
| expect(decoded.order_field_value).to eq record.created_at | ||
| end |
There was a problem hiding this comment.
I can't personally think of a way to do this, but it would be nice to have an assertion that tests nanosecond precision explicitly, instead of relying on an equality check on two Time objects, which inherently have that precision built in. Idk, I always hated testing timestamps so I think this is good.
| "The given cursor `#{encoded_string}` was decoded as " \ | ||
| "`#{decoded}` but could not be parsed" | ||
| end | ||
| if decoded[0].is_a?(Hash) |
There was a problem hiding this comment.
decoded[0] could be turned into a hash for reasons other than this one right? So is it worth adding a check here for seconds and nanoseconds keys?
if decoded[0].is_a?(Hash) && ['seconds', 'nanoseconds'].all? { |key| decoded[0].key? key }
amandawraymond
force-pushed
the
ar/support_sorting_by_datetime
branch
5 times, most recently
from
76c0d62
to
59949bb
Compare
…rsors add spec coverage for timestamp order_by selector in pagination fetch Bump version to 0.3.1
amandawraymond
force-pushed
the
ar/support_sorting_by_datetime
branch
from
59949bb
to
62a40df
Compare
| @@ -49,7 +49,7 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| strategy: | |||
| matrix: | |||
| ruby-version: ['2.6', '2.7', '3.0', '3.1'] | |||
There was a problem hiding this comment.
versions fail on workflow
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module RailsCursorPagination | |||
| VERSION = '0.3.0' | |||
There was a problem hiding this comment.
bump version
| @@ -23,18 +24,19 @@ class Post < ActiveRecord::Base; end | |||
| ActiveRecord::Migration.verbose = ENV.fetch('VERBOSE', nil) | |||
|
|
|||
| ActiveRecord::Base.establish_connection( | |||
| adapter: ENV.fetch('DB_ADAPTER', 'mysql2'), | |||
There was a problem hiding this comment.
default to postgres
| # Ensure we have an empty `posts` table with the right format | ||
| ActiveRecord::Migration.drop_table :posts, if_exists: true | ||
|
|
||
| ActiveRecord::Migration.create_table :posts do |t| | ||
| t.string :author | ||
| t.string :content | ||
| t.timestamps |
There was a problem hiding this comment.
add timestamped columns to compare in specs
Problem
Reported DateTime Issue
Solution
ensure the serialization and deserialization via JSON of the Cursors handle the precision of DateTime data down to the nanosecond
Details