fix: correct condition to accept id equal zero (#3936)

src/components/List/ListAccordion.tsx

@@ -203,7 +203,7 @@ const ListAccordion = ({
   const expandedInternal = expandedProp !== undefined ? expandedProp : expanded;
 
   const groupContext = React.useContext(ListAccordionGroupContext);
-  if (groupContext !== null && !id) {
+  if (groupContext !== null && (id === undefined || id === null || id === '')) {
     throw new Error(
       'List.Accordion is used inside a List.AccordionGroup without specifying an id prop.'
     );

src/components/__tests__/ListAccordion.test.tsx

@@ -1,12 +1,13 @@
 import * as React from 'react';
-import { StyleSheet } from 'react-native';
+import { StyleSheet, View } from 'react-native';
 
 import { render } from '@testing-library/react-native';
 import color from 'color';
 
 import { getTheme } from '../../core/theming';
 import { red500 } from '../../styles/themes/v2/colors';
 import ListAccordion from '../List/ListAccordion';
+import ListAccordionGroup from '../List/ListAccordionGroup';
 import ListIcon from '../List/ListIcon';
 import ListItem from '../List/ListItem';
 import { getAccordionColors } from '../List/utils';
@@ -84,6 +85,36 @@ it('renders list accordion with custom title and description styles', () => {
   expect(tree).toMatchSnapshot();
 });
 
+describe('ListAccordion', () => {
+  it('should not throw an error when id={0}', () => {
+    const ListAccordionTest = () => (
+      <ListAccordionGroup>
+        <ListAccordion title="Testing list" id={0}>
+          <View></View>
+        </ListAccordion>
+      </ListAccordionGroup>
+    );
+
+    expect(() => render(<ListAccordionTest />)).not.toThrow(
+      'List.Accordion is used inside a List.AccordionGroup without specifying an id prop.'
+    );
+  });
+
+  it('should throw an error when id={""}', () => {
+    const ListAccordionTest = () => (
+      <ListAccordionGroup>
+        <ListAccordion title="Testing list" id={''}>
+          <View></View>
+        </ListAccordion>
+      </ListAccordionGroup>
+    );
+
+    expect(() => render(<ListAccordionTest />)).toThrow(
+      'List.Accordion is used inside a List.AccordionGroup without specifying an id prop.'
+    );
+  });
+});
+
 describe('getAccordionColors - title color', () => {
   it('should return theme color, for theme version 3', () => {
     expect(