fix: padding in flat text input on web #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
|
@unikvozm Do you know what is the root of that inconsistency between mobile and web? That issue is web-specific and I am trying to understand if there is a way to fix it in a root instead of adding some padding here and there :D |
|
@Trancever, yeah, the different logic was for web and mobiles: for web it was padding 36 only, and for mobiles: margin 36 and padding 8 and now it is the same on all platforms. |
Trancever
approved these changes
Dec 14, 2020
|
Thank you @unikvozm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2402
Test plan