fix: allow setting accessibility prop for Button component #2448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In my current project I have a very specific business requirement: in a web version of application few buttons need to be taken out of keyboard navigation flow (using tab key) while at the same time still being clickable by mouse. Using
disabled
prop will obviously break second part of the requirement so I've investigated a little how other accessibility-related props do work in react-native-web and it turned out thataccessible
prop is exactly what I'm looking for. Unfortunately in Paper's<Button />
componentaccessible
prop is passed to the wrapping<Surface />
component, not the<TouchableRipple />
which is then rendering<TouchableWithoutFeedback />
. That is makingaccessible
prop have no effect.This PR is fixing that issue but for some reason some of the library users may depend on passing
accessible
prop to the wrapping<Surface />
so it is possibly a Breaking Change.