Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove additional outline from web inputs #2654

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

lukewalczak
Copy link
Member

Fixes: #2598

Summary

That PR is removing the outline from web text input which is overlapping with component border.
NOTE: we are providing the visual indicator/effect when input if focused, so there is no regression in terms of accessibility.

Test plan

  1. Use text input on the web
  2. Focus the text input
  3. Expect there is additional outline
before after
image image

@lukewalczak lukewalczak self-assigned this Apr 9, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

The mobile version of example app from this branch is ready! You can see it here

.

Copy link
Contributor

@Trancever Trancever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lukewalczak lukewalczak merged commit 7516517 into main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput with mode outlined - Outline over label when focused
2 participants