Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch for text input label #2678

Merged
merged 1 commit into from
Apr 23, 2021
Merged

fix: patch for text input label #2678

merged 1 commit into from
Apr 23, 2021

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Apr 23, 2021 •
edited
Loading

Fix the regression introduced in: #2672

Summary

before after
Zrzut ekranu 2021-04-23 o 14 36 32 Zrzut ekranu 2021-04-23 o 14 36 19

Test plan

  1. Set in theme roundess: 25
  2. Focus outlined text input with label
    Expect: there are no bug related to bottom border

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 4bba7d4 into main Apr 23, 2021
@lukewalczak lukewalczak deleted the fix/text-input-label-patch branch April 23, 2021 12:46
@brunohkbx brunohkbx mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trancever Trancever Trancever approved these changes

Assignees
No one assigned
Labels
TextInput
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @Trancever