Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce prop for defining control position (leading/trailing) fo RadioButton.Item #2713

Merged
merged 2 commits into from
May 27, 2021

Conversation

lukewalczak
Copy link
Member

Fixes: #2704

Summary

This PR extends RadioButton.Item component and introduces new prop to define radio button control position - leading/trailing

iOS

ltr rtl
ios_ltr ios_rtl

Android

ltr rtl
a_ltr a_rtl_2

Test plan

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@callstack-bot
Copy link

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak changed the title feat: introduce prop for defining control position (leading/trailing) feat: introduce prop for defining control position (leading/trailing) fo RadioButton.Item May 19, 2021
@lukewalczak lukewalczak merged commit ddd6a7c into main May 27, 2021
@lukewalczak lukewalczak deleted the feat/radio-button-icon-position branch May 27, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for RadioButton.Item with radio button icon on the left, instead of on the right
4 participants