fix: fix regression in Appbar.Header statusBarHeight #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I recently tested
5.0.0-rc2and noticed a regression on theAppbar.HeaderSummary
I use it this way:
<Appbar.Header statusBarHeight={0}>.However, it is not working like before and I have a huge space instead.
The regression seems to come from this change:
c0f5007#diff-6d75c85ccdc33452375c1e517435df14b568c580a394df5c3c7b3f05add5bfa5R135
If
0then it will default onAPPROX_STATUSBAR_HEIGHTinstead of allowing it as valid value.Test plan
Before PR:
<Appbar.Header statusBarHeight={0}>=>paddingTop = APPROX_STATUSBAR_HEIGHTAfter PR:
<Appbar.Header statusBarHeight={0}>=>paddingTop = 0