Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NotificationsRoute causing error #3326

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

smolpaw
Copy link
Contributor

@smolpaw smolpaw commented Aug 20, 2022

Missing NotificationsRoute and notifications key in SceneMap

@callstack-bot
Copy link

callstack-bot commented Aug 20, 2022

Hey @Dragonxp, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak
Copy link
Member

Hey @Dragonxp, could you please rename the commit to follow the commit naming convention?

@smolpaw smolpaw changed the title Fixed NotificationsRoute causing error fix: Fix NotificationsRoute causing error Aug 22, 2022
@smolpaw smolpaw changed the title fix: Fix NotificationsRoute causing error fix: Fixed NotificationsRoute causing error Aug 22, 2022
@smolpaw
Copy link
Contributor Author

smolpaw commented Aug 22, 2022

Hey @Dragonxp, could you please rename the commit to follow the commit naming convention?

Done

@lukewalczak
Copy link
Member

I still can see that commit is named Fixed NotificationsRoute causing error.

Missing NotificationsRoute and notifications key in SceneMap
@smolpaw smolpaw changed the title fix: Fixed NotificationsRoute causing error fix: NotificationsRoute causing error Aug 22, 2022
@smolpaw
Copy link
Contributor Author

smolpaw commented Aug 22, 2022

Fixed now fix: NotificationsRoute causing error

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukewalczak lukewalczak merged commit 6ff9a20 into callstack:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants