-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Pressable in TouchableRipple #3400
feat: use Pressable in TouchableRipple #3400
Conversation
Hey @szymonrybczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this PR, much appreciated 🌟.
There are a couple changes that can be addressed.
@szymonrybczak Additionally, there are some regressions that causes instability on web. I am attaching the screenshots of the relevant components that are affected by the PR changes. If you can take a look at these, it will be so helpful. Platform(web):
|
@hurali97 Yes, sure. This was really the problem, I fixed it! 😅 |
@szymonrybczak thanks for adjusting the comments and fixing the issue! @hurali97 could you please give another round of testing and checking the PR? 👌🏽 |
@szymonrybczak Thanks for incorporating them real quick. 🌟 @lukewalczak I'll re-run the tests and re-review the PR tomorrow morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉 Thanks @szymonrybczak for your effort and @hurali97 for reviewing and testing the PR!
This PR replaces
Touchables
withPressable
withinTouchableRipple
.Related issues:
Summary
Test plan