fix: input icon custom color #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
gedu
reviewed
Jun 26, 2023
| @@ -131,7 +131,7 @@ const TextInputIcon = ({ | |||
| icon, | |||
| onPress, | |||
| forceTextInputFocus, | |||
| color, | |||
| color: customColor, | |||
There was a problem hiding this comment.
Should we add into the Omit the iconColor prop? to avoid confusion?
$Omit<
React.ComponentProps<typeof IconButton>,
'icon' | 'theme' | 'color'|'iconColor'
>
|
LGTM, small suggestion |
gedu
approved these changes
Jun 26, 2023
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3901
Summary
Corrects using the custom color in to
TextInput.Icon.Related issue
Test plan
Tested manually in the app on the second example.