Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection and cursor colors #4016

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

lukewalczak
Copy link
Member

Fixes: #4011

Summary

  • adjusting default selection color on Android, which was opaque
  • extracting Underline and Outline to separate files in Addons directory
  • adjust example for TextInput

Test plan

Updated snapshots

@callstack-bot
Copy link

callstack-bot commented Aug 6, 2023

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak merged commit 4faddd9 into main Aug 9, 2023
3 checks passed
@lukewalczak lukewalczak deleted the fix/input-selection-and-cursor-color branch August 9, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput selectionColor is opaque on Android, which makes text hard to read
2 participants