fix: improve screen reader experience by fixing redundant FAB.Group item announcements. #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @abdulbasithqb, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
fix: screen reader navigation in FAB.Group - IOS
|
iOS changes have been incorporated to improve accessibility IOS-VoiceOver.mov |
lukewalczak
reviewed
Jan 8, 2024
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityRole="button" | ||
| importantForAccessibility="no-hide-descendants" | ||
| accessibilityElementsHidden={true} |
There was a problem hiding this comment.
Suggested change
| accessibilityElementsHidden={true} | |
| accessibilityElementsHidden |
lukewalczak
approved these changes
Jan 8, 2024
| @@ -408,6 +412,8 @@ const FABGroup = ({ | |||
| > | |||
| <Text | |||
| variant="titleMedium" | |||
| importantForAccessibility="no-hide-descendants" | |||
| accessibilityElementsHidden={true} | |||
There was a problem hiding this comment.
Suggested change
| accessibilityElementsHidden={true} | |
| accessibilityElementsHidden |
| @@ -429,13 +435,13 @@ const FABGroup = ({ | |||
| isV3 && { transform: [{ translateY: translations[i] }] }, | |||
| it.style, | |||
| ]} | |||
| accessibilityElementsHidden={true} | |||
There was a problem hiding this comment.
Suggested change
| accessibilityElementsHidden={true} | |
| accessibilityElementsHidden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal is to enhance the screen reader experience by resolving redundant item announcements in the FAB.Group.
Related Issue
Fixes #4063
Test Plan
Check FAB.Group Presence:
Android Testing (TalkBack):
iOS Testing (VoiceOver):
Remember to document any findings, changes, or considerations during the testing process. This comprehensive plan should help ensure a thorough evaluation of the accessibility improvements across different platforms and devices.
Result
accessiblity-issue.webm
IOS-VoiceOver.mov