fix: adjust native driver value based on the rn version #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
mnahkies
added a commit
to mnahkies/react-native-paper
that referenced
this pull request
Jan 6, 2024
in callstack#4246 a check based on react native version was introduced, however the `Platform.constants` property is `undefined` when targetting web using the `react-native-web` approach listed in the docs, as the platform object is simply: ``` {"OS":"web","isTesting":false} ``` adjust it to check if the `OS` is `web` and use the native driver as before if so.
|
@lukewalczak I think this created a regression for those targeting web using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adjust the
useNativeDrivervalue in shadow animation to be based on thereact-nativeversion.Related issue
Test plan
Tested on react-native version 0.71, 0.72 and 0.73