fix: force cast await to proper type #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
commented
Jan 26, 2023
mdjastrzebski
requested review from
thymikee,
AugustinLF,
MattAgn and
pierrezimmermannbam
AugustinLF
reviewed
Jan 26, 2023
|
|
||
| function withGlobalActEnvironment(actImplementation: Act) { | ||
| return (callback: Parameters<Act>[0]) => { | ||
| function withGlobalActEnvironment(actImplementation: ReactAct) { |
There was a problem hiding this comment.
Is it even useful to pass it actImplementation as a param?
There was a problem hiding this comment.
hmmmm, good question, we've got our code from RTL and just sprinkled types and eslint ignores over it.
I guess it's easier to keep it in sync with their implmentation.
AugustinLF
approved these changes
Jan 26, 2023
thymikee
reviewed
Jan 26, 2023
thymikee
approved these changes
Jan 26, 2023
Codecov ReportBase: 95.19% // Head: 95.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 95.19% 95.98% +0.78%
==========================================
Files 47 47
Lines 3249 3240 -9
Branches 489 489
==========================================
+ Hits 3093 3110 +17
+ Misses 156 130 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve typing issues with
actby allowing to invoke bothact()andawait act(). Reactacthas uses function overloading which is hard to work with, so I've resorted to casting.Dropping support for mock
actand increasing peer dep req to React 16.8 (earliest version to expose act in Test Renderer). I think we can avoid calling this a breaking change, as we already specified minimal RN version of 0.59, which uses React 16.8.3 (see here)Resolves #1276
Resolves #1207
Test plan
Typecheck runs fine.