-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BREAKING) feat: make wrapper option compatible with RTL/RNTL #399
Conversation
🦋 Changeset detectedLatest commit: 038f41f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Performance Comparison ReportSignificant Changes To Render Duration
Show details
Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
9b13c87
to
54d8208
Compare
cc @vnovick you'll like it :) |
Let's make sure all examples are updated |
54d8208
to
3f06aab
Compare
@thymikee there aren't any examples using it 🤣 |
Summary
Currently the
wrapper
option accepts a wrapping function:However, both RNTL and RTL accept a wrapper component type:
Each approach can be relatively easy transformed to the other one, but having slightly different wrapper types make adapting tests from RNTL, RTL slightly more cumbersome.
This is a breaking change, but since we are pre 1.0 version it should result in minor version change (probably 0.9.0).
Test plan
Added test that checks if the wrapper is placed in the proper place in the element tree.